Skip to content

add tests for checking that goals are correctly shown#585

Merged
hendriktews merged 1 commit into
ProofGeneral:masterfrom
hendriktews:missing-goals
Feb 18, 2024
Merged

add tests for checking that goals are correctly shown#585
hendriktews merged 1 commit into
ProofGeneral:masterfrom
hendriktews:missing-goals

Conversation

@hendriktews

Copy link
Copy Markdown
Collaborator

Most of these tests currently fail because of different instances
of #568, see also #429, #467.

@hendriktews

Copy link
Copy Markdown
Collaborator Author

All the currently failing tests have :expected-result :failed, therefore the checks are reported as passed.

@Columbus240

Columbus240 commented Jun 25, 2021

Copy link
Copy Markdown
Contributor

Maybe also consider adding tests for #103 and #102 (or checking whether the current tests are already appropriate). Another example similar to #103 : Goal True. Abort.

@hendriktews hendriktews force-pushed the missing-goals branch 2 times, most recently from f0ccaf8 to 410d1d9 Compare January 28, 2024 20:51
Most of these tests currently fail because of different instances
of ProofGeneral#568, see also ProofGeneral#429, ProofGeneral#467, ProofGeneral#103.
@hendriktews hendriktews merged commit a6bd818 into ProofGeneral:master Feb 18, 2024
@hendriktews hendriktews deleted the missing-goals branch February 18, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants